Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the repository config in spring cloud azure pom files #31086

Conversation

moarychan
Copy link
Member

@moarychan moarychan commented Sep 22, 2022

  • Add a sparse-checkout path
  • Remove unnecessary repository config in each spring project when it depends on azure-client-sdk-parent.
  • When not dependent on azure-client-sdk-parent, configure spring milestone repo for spring cloud azure starter.

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added the azure-spring All azure-spring related issues label Sep 22, 2022
@azure-sdk
Copy link
Collaborator

azure-sdk commented Sep 22, 2022

API change check

APIView has identified API level changes in this PR and created following API reviews.

spring-cloud-azure-core
spring-messaging-azure-eventhubs
spring-messaging-azure-servicebus
spring-cloud-azure-autoconfigure

@moarychan moarychan marked this pull request as ready for review September 22, 2022 06:39
@moarychan moarychan self-assigned this Sep 22, 2022
@moarychan moarychan added this to the 2022-10 milestone Sep 22, 2022
@moarychan
Copy link
Member Author

@saragluna please help to review, thanks!

@moarychan moarychan merged commit 7b5d93b into Azure:feature/spring-cloud-azure-6.x Sep 26, 2022
@moarychan moarychan deleted the moary/update-repository-config branch September 26, 2022 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-spring All azure-spring related issues
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants